Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod tidy to fix version of github.com/yujunz/go-getter #2263

Closed
wants to merge 1 commit into from
Closed

go mod tidy to fix version of github.com/yujunz/go-getter #2263

wants to merge 1 commit into from

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Mar 7, 2020

The tag has been fixed to follow the original, i.e. v1.4.1 => v1.4.1-lite

Previously v1.5.3-lite was tagged for exploring the go mod behavior

@yujunz
go mod tidy to fix version of github.com/yujunz/go-getter
fc7b8a1 
The tag has been fixed to follow the original, i.e. v1.4.1 => v1.4.1-lite

Previously v1.5.3-lite was tagged for exploring the go mod behavior
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2020
@yujunz
Copy link
Member Author

yujunz commented Mar 7, 2020

Integration test and examples in work in progress and will land soon. @Liujingfang1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yujunz
To complete the pull request process, please assign liujingfang1
You can assign the PR to them by writing /assign @liujingfang1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujunz
Copy link
Member Author

yujunz commented Mar 7, 2020

/assign @Liujingfang1

@yujunz
Copy link
Member Author

yujunz commented Mar 7, 2020 •
edited
Loading

There seems some regression failure with existing examples.

go run . build github.com/kubernetes-sigs/kustomize/examples/multibases/dev/\?ref=v1.0.6
Error: Error demand directory "evalsymlink failure on 'github.com/kubernetes-sigs/kustomize/examples/multibases/dev/?ref=v1.0.6' : lstat /Users/yujunz/Code/kubernetes-sigs/kustomize/kustomize/github.com: no such file or directory" and create loader "subdir \"examples/multibases/dev/%253Fref=v1.0.6\" not found"
exit status 1

I would suggest reverting #2169 for now and hold until it is covered by tests. Sorry for not marking the PR status clearly.

@yujunz yujunz closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@Liujingfang1 Liujingfang1

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yujunz @k8s-ci-robot @Liujingfang1